Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error checking for adminUpdates is non-existent #104

Open
youralien opened this issue Apr 7, 2019 · 0 comments
Open

Error checking for adminUpdates is non-existent #104

youralien opened this issue Apr 7, 2019 · 0 comments

Comments

@youralien
Copy link
Member

I encountered an issue when I miss-used the function signature in adminUpdatesForRemovingUserToIncidentEntirely, where an error is not thrown or printed if these admin updates don't work out.

These functions should implement contracts on the inputs, and check if the expected number of documents got updated, and throw or log errors in the console.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant