Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in Metadata viewers #332

Open
dmachi opened this issue Mar 16, 2023 · 3 comments
Open

Bug in Metadata viewers #332

dmachi opened this issue Mar 16, 2023 · 3 comments
Assignees
Labels
bug Something isn't working important

Comments

@dmachi
Copy link
Contributor

dmachi commented Mar 16, 2023

If you go to https://net.science/files/resources/epihiper/examples/example_1/ there are two epihiper files loaded there. If you go to the metadata right hand panel, it crashes the UI.

Secondly, there are no default viewers for those types. Could you please add these to the default viewers. In fact, I think the current message of "No viewer available for files of this type" shouldn't be used. Instead, there should be a default viewer that is essentially the "text" viewer. This is only problematic for binary files, so we'll need to figure out that too. However, our default viewer could at least be everything except the "data" tab and allow the users to download.

@Vaibhav-Sontakke1
Copy link

• User would be able to view the metadata of the selected file, on click of metadata tab displayed in right pane
Note – Metadata tab would not be crashed on click of it.

• If the file manager config file does not contain the uploaded file type that is present in the file manager tab then the file type would be considered as “text” by default and “Text Viewer” would be used to display the file content.

• If any file attribute value in the metadata panel has the type object, JSONTree will be utilized to render the object in a tree-like structure so that it is in a readable format.

@dmachi
Copy link
Contributor Author

dmachi commented Apr 18, 2023

I reviewed this on ptest. For the default viewer as the text viewer, there is one issue. It should be if the filemanager config does not container the uploaded file type AND isContainer is false. The current implementation prevents you from going into "container" objects (like exceads experiment output).

@dmachi
Copy link
Contributor Author

dmachi commented May 16, 2023

This is mostly working now. Since the default viewer is text now, we have the opposite issue in at least one case....excel files. You can test this by uploading an excel file (type 'excel'). It will show the binary data on the data tab. My recommended solution for this would be to create a "blacklist" of file types that it will not attempt to render. It should still go to the file landing page, but it won't have a "data" tab (or a data tab with only the message about the file not being viewable in the browser).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working important
Projects
None yet
Development

No branches or pull requests

4 participants