-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sam 391 ssc 825 merchant plant forecast upgrades #1235
Merged
brtietz
merged 22 commits into
develop
from
sam_391_ssc_825_merchant_plant_forecast_upgrades
Nov 6, 2024
Merged
Sam 391 ssc 825 merchant plant forecast upgrades #1235
brtietz
merged 22 commits into
develop
from
sam_391_ssc_825_merchant_plant_forecast_upgrades
Nov 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or FOM automated and manual dispatch
…terconnection_limits
…ndently from system power
…tional for fom automated and manual dispatch.
…terconnection_limits
…terconnection_limits
…terconnection_limits
…akes it to the grid at the interconnection limit
…icant decrease in curtailed energy when the battery is not full
…terconnection_limits
… Works well for the current step, neglects to charge for future steps. More charging code required
…terconnection_limits
…rchant_plant_forecast_upgrades
…c_825_merchant_plant_forecast_upgrades
cpaulgilman
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation is somewhat weighted to "charge as soon as possible to meet cleared capacity" but seems to meet cleared capacity requirements. I have some ideas on how to back it off and make it more economic if users complain.
Closes #825
Also closes NREL/SAM#391
Test file:
merchant_plant_dispatch_test_single_cc.zip
Note that markets can be all based on percent of generation, all based on cleared capacity, or a combination! This should handle all of the above, but requires large batteries and a small % of generation to make it through to the end.
It might be nice for debugging to make some of the merchant plant errors optional to assist with sizing and debugging for these types of applications. Probably not a feature for this release though.