Noct taualpha #1233
Noct taualpha #1233
Conversation
|
Need to discuss with @sjanzou how to update remaining tests, but otherwise should be good to review as is. |
| @@ -1,5 +1,5 @@ | |||
| { | |||
| "solar_resource_file" : "C:/Projects/Github/NREL/working/SAM/deploy/solar_resource/phoenix_az_33.450495_-111.983688_psmv3_60_tmy.csv", | |||
| "solar_resource_file" : "C:/Users/mprillim/sam_dev/SAM/deploy/solar_resource/phoenix_az_33.450495_-111.983688_psmv3_60_tmy.csv", | |||
There was a problem hiding this comment.
It looks like this line was specific to Steve's computer before, and is now specific to yours, but flagging in case it should be set to a common file... but I don't think there's an easy way to use environment variables in JSON, is there @sjanzou ? I don't require this to be fixed before merging though.
There was a problem hiding this comment.
It looks like this line was specific to Steve's computer before, and is now specific to yours, but flagging in case it should be set to a common file... but I don't think there's an easy way to use environment variables in JSON, is there @sjanzou ? I don't require this to be fixed before merging though.
@janinefreeman , thanks for flagging this - the JSON generated always has the specific test machine path... However, in the test body, the weather file is updated to use
the "Test" function, where the weather file is set based on the SSCDIR/test/input_cases/general_data folder as
| @@ -1,5 +1,5 @@ | |||
| { | |||
| "solar_resource_file" : "C:/Projects/Github/NREL/working/SAM/deploy/solar_resource/phoenix_az_33.450495_-111.983688_psmv3_60_tmy.csv", | |||
| "solar_resource_file" : "C:/Users/mprillim/sam_dev/SAM/deploy/solar_resource/phoenix_az_33.450495_-111.983688_psmv3_60_tmy.csv", | |||
There was a problem hiding this comment.
same comment as the other JSON file (and so on for all the JSONs)
|
@sjanzou @brtietz is there known variance for ResidentialDCBatteryModelPriceSignalDispatch test across operating systems. I show this test as passing on Windows and Linux but failing on Mac for these temperature model changes. The battery capacity percent variable change on Mac, which I suppose is possible for different values in gen but I'm confused why it wouldn't show up across operating systems. |
-Use Geff_total in NOCT model rather than G_total, remove irradiance scaling of tau*alpha product
-Update tests
-Fixes #917