You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
The battery stateful model of SAM doesn't compute the outputs n_replacements and indices_replaced even after giving the required replacement inputs replacement_option, replacement_capacity .
To Reproduce
Steps to reproduce the behavior:
Please run the simulation in the attached jupyter notebook ( rename from txt to ipynb , alternative is to create a script with required inputs and replacement options and run the calculation battery_stateful bug.txt
Expected behavior
The replacement outputs should be calculated correctly
Additional context
After doing a static code analysis, I can see the runReplacement method of battery model is not called inside cmod_battery_stateful.cpp . This could be the reason why the replacements are not calculated
The text was updated successfully, but these errors were encountered:
Describe the bug
The battery stateful model of SAM doesn't compute the outputs n_replacements and indices_replaced even after giving the required replacement inputs replacement_option, replacement_capacity .
To Reproduce
Steps to reproduce the behavior:
Please run the simulation in the attached jupyter notebook ( rename from txt to ipynb , alternative is to create a script with required inputs and replacement options and run the calculation
battery_stateful bug.txt
Expected behavior
The replacement outputs should be calculated correctly
Additional context
After doing a static code analysis, I can see the runReplacement method of battery model is not called inside cmod_battery_stateful.cpp . This could be the reason why the replacements are not calculated
The text was updated successfully, but these errors were encountered: