Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New ResStockArgumentsPostHPXML measure #927

Open
joseph-robertson opened this issue May 12, 2022 · 9 comments · May be fixed by #929
Open

New ResStockArgumentsPostHPXML measure #927

joseph-robertson opened this issue May 12, 2022 · 9 comments · May be fixed by #929
Assignees
Labels

Comments

@joseph-robertson
Copy link
Contributor

joseph-robertson commented May 12, 2022

Update the workflow to accommodate writing detailed schedule csv files. This will support:

Proposal:

BuildExistingModel (and ApplyUpgrade) calls, in order:

  • ResStockArguments
  • BuildResidentialHPXML
  • BuildResidentialScheduleFile
  • ResStockArgumentsPostHPXML
    • Input:
      • hpxml_path
      • output_csv_path (for schedules.csv generated by BuildResidentialScheduleFile)
      • New arguments from options_lookup.tsv
    • Output:
      • schedules2.csv (updates hpxml_path's <SchedulesFilePath>)
  • HPXMLtoOpenStudio
  • ReportSimulationOutput
  • ...
@joseph-robertson
Copy link
Contributor Author

Thoughts/suggestions? Should I move forward with this?

@shorowit @aspeake @ejhw @afontani @whiphi92

@ejhw
Copy link
Contributor

ejhw commented May 13, 2022

I defer to Scott on whether this is a good method. Can the setpoint schedules be appended to the existing schedules.csv or is there a reason they need to be separate?

@joseph-robertson
Copy link
Contributor Author

I think, yes, we could append new schedules to the existing schedules.csv.

@ejhw
Copy link
Contributor

ejhw commented May 13, 2022

Cool; it seems easier from a user perspective.

@joseph-robertson joseph-robertson linked a pull request May 13, 2022 that will close this issue
5 tasks
@shorowit
Copy link
Contributor

Note that appending new schedules will have a runtime performance impact because you have to read in the entire CSV, add the columns, and then write it back out. Might check how much time that takes for a 10-min or 1-min simulation.

@shorowit
Copy link
Contributor

I guess we're having to read the entire CSV either way to find the occupied/unoccupied hours for use in the HVAC setpoint generation. But writing to disk is the expensive operation.

@ejhw
Copy link
Contributor

ejhw commented May 16, 2022

Thanks. I'm fine with separate files if we think it is worth the time savings. cc @afontani in case he has an opinion on this.

@joseph-robertson
Copy link
Contributor Author

Are we going to be able to create new setpoint TSV files that avoid htg_stpt > clg_stpt? Or do we need to build/use the same type of "averaging" approach that OS-HPXML uses?

@ejhw

@ejhw
Copy link
Contributor

ejhw commented May 16, 2022

@joseph-robertson I don't think we do anything special to handle that now.

@joseph-robertson joseph-robertson changed the title ResStockArguments refactor New ResStockArgumentsPostHPXML measure May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants