Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checks to filter arguments for TrendAnalysis (Issue #377) #436

Open
wants to merge 2 commits into
base: development
Choose a base branch
from

Conversation

martin-springer
Copy link
Collaborator

@martin-springer martin-springer commented Nov 6, 2024

  • Code changes are covered by tests
  • Code changes have been evaluated for compatibility/integration with TrendAnalysis
  • New functions added to __init__.py
  • API.rst is up to date, along with other sphinx docs pages
  • Example notebooks are rerun and differences in results scrutinized
  • Updated changelog

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 81.39535% with 8 lines in your changes missing coverage. Please review.

Project coverage is 95.82%. Comparing base (b3927da) to head (0da2f0f).

Files with missing lines Patch % Lines
rdtools/analysis_chains.py 81.39% 8 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           development     #436      +/-   ##
===============================================
- Coverage        96.19%   95.82%   -0.38%     
===============================================
  Files               11       11              
  Lines             2209     2250      +41     
===============================================
+ Hits              2125     2156      +31     
- Misses              84       94      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants