Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TrendAnalysis uses power_expected for both sensor- and clearsky-based workflows #271

Open
kandersolar opened this issue Apr 12, 2021 · 1 comment

Comments

@kandersolar
Copy link
Member

Not necessarily a bug, but a perhaps unintuitive behavior: when passing in an external power_expected time series, it is used for both sensor-based and clearsky-based workflows. To my mind, part of the spirit behind the clear-sky workflow is that the normalization is tied to the modeled clear-sky irradiance, which is not the case when using a custom power_expected. I think if passing in an external power_expected time series, the sensor and clear-sky workflows become identical except for the csi_filter (not 100% sure about this though).

Some ideas:

  • Separate power_expected_sensor and power_expected_clearsky inputs
  • Keep the code the way it is now, but emit a warning if power_expected is used in the clear-sky workflow
  • Do nothing, because the code is just doing what you told it to do
@martin-springer
Copy link
Collaborator

Let's implement the warning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants