Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs #1034

Merged
merged 6 commits into from
Nov 21, 2024
Merged

Fix docs #1034

merged 6 commits into from
Nov 21, 2024

Conversation

paulf81
Copy link
Collaborator

@paulf81 paulf81 commented Nov 20, 2024

Fix docs

Recently the documentation failed to build:

https://github.com/NREL/floris/actions/runs/11938591041

I believe I've traced the issue to the recent version bump of autoyaml to 1.1.2. Locally at least, pinning to 1.1.1 resolves the issue. I've also posted a question as an issue here:

Jakski/sphinxcontrib-autoyaml#26

I think the PR should fix it in github actions as well. Then also:

  • I set back python to 3.10 for building docs as this has worked in the past
  • Fix a minor test issue that came up in the course of this.

@paulf81 paulf81 added bug Something isn't working documentation labels Nov 20, 2024
@paulf81 paulf81 self-assigned this Nov 20, 2024
@misi9170
Copy link
Collaborator

misi9170 commented Nov 21, 2024

@rafmudaf in #1019, we moved to building the docs with python 3.13 rather than 3.10---was the purpose of that to keep up to date with the latest python? I believe the failed deploy-pages action, triggered by merging #1026, is the first time the deploy-pages action ran since #1019 was merged, so just wanted to check if that could have been the root issue

@rafmudaf
Copy link
Collaborator

The intent was to use a consistent Python version across all CI jobs aside from the automated tests which has a matrix of Python versions. I chose 3.13 only because it's the latest.

As for the failing build, @paulf81 noted it was due to a version incompatibility with sphinxcontrib-autoyaml. Is it also related to the Python version?

@paulf81
Copy link
Collaborator Author

paulf81 commented Nov 21, 2024

The intent was to use a consistent Python version across all CI jobs aside from the automated tests which has a matrix of Python versions. I chose 3.13 only because it's the latest.

As for the failing build, @paulf81 noted it was due to a version incompatibility with sphinxcontrib-autoyaml. Is it also related to the Python version?

You're right, the python version ended up being a red herring. I've restored 3.13 and checked locally and docs build. I also have a response on the autoyaml issue that we should stay pinned and they'll let us know when ok to update.

@misi9170
Copy link
Collaborator

Thanks @rafmudaf , @paulf81 ! I'll try building locally this morning and hopefully we can get this merged.

@rafmudaf
Copy link
Collaborator

If you want to test it on GitHub, just change the Actions job to build on any event:

on:
  push:
#    branches:
#    - develop
#    paths:
#    - docs/**

and comment out the part where it uploads to GitHub pages:

    # Push the book's HTML to github-pages
#    - name: GitHub Pages action
#      uses: peaceiris/[email protected]
#      with:
#        github_token: ${{ secrets.GITHUB_TOKEN }}
#        publish_dir: ./docs/_build/html

@misi9170
Copy link
Collaborator

misi9170 commented Nov 21, 2024

Local build worked for me after the change. Trying a build on github actions according to @rafmudaf 's suggestion now. Here is the action: https://github.com/paulf81/floris/actions/runs/11958839662 (still in progress currently...)

Update: success! Will revert the changes now, and then I think we can merge.

@misi9170 misi9170 merged commit d961a74 into NREL:develop Nov 21, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants