Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove testing for Mac OS for FLORIS v2 #1020

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

misi9170
Copy link
Collaborator

@misi9170 misi9170 commented Nov 8, 2024

As suggested by @rafmudaf in #1008 , this PR removes Mac OS tests from the testing matrix for FLORIS v2. This will address failing tests in #1008, as well as previous PRs to v2 (e.g. #734 ).

Assuming this is fine, we can merge this PR ahead of #1008 so that tests pass on that PR prior to merger. I will then increment the version number on v2 and create a v2.5.2 release.

@misi9170 misi9170 added the v2.x Related to any version of FLORIS less than v3 label Nov 8, 2024
Copy link
Collaborator

@rafmudaf rafmudaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @misi9170

@misi9170 misi9170 merged commit 4aff543 into NREL:v2 Nov 8, 2024
4 checks passed
@misi9170 misi9170 deleted the v2-ms/rm-macos-tests branch November 8, 2024 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v2.x Related to any version of FLORIS less than v3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants