Test on all supported Python versions #1019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pages build and speed check are on the latest version only
The pip to merge dicts is supported in Python 3.9+; replace with the dict.update method
misi9170
approved these changes
Nov 15, 2024
There was a problem hiding this comment.
Thanks for doing this @rafmudaf . As we've mentioned briefly in a couple of different places, we may move to drop support for older versions of python (3.8 and possibly 3.9) but that should be a separate PR after a dedicated discussion on the matter---so, nothing to do here, just logging it. This all looks good to me.
|
Thanks @rafmudaf this is great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the Python project configuration, FLORIS supports Python versions
>=3.8.0. However, the automated checks through GitHub Actions are testing inconsistent and incomplete versions, as shown below.This pull request updates these workflows to support Python v3.13 and moves the pages build and speed checks to 3.13. The version changes are captured below.
For context, testing on all supported versions helps to catch backward compatibility errors such as the lack of importing
annotationswhen we use the pipe (|) for type hinting.NOTE: One of the examples fails with Python 3.8. Prior to merging, this should be resolved so that the CI doesn't always fail- Done in the last commit