Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Cathode pressure to be 30bar #61

Open
nRiccobo opened this issue Aug 2, 2023 · 0 comments
Open

Update Cathode pressure to be 30bar #61

nRiccobo opened this issue Aug 2, 2023 · 0 comments
Assignees
@nRiccobo
Labels
enhancement New feature or request

Comments

@nRiccobo
Copy link
Collaborator

nRiccobo commented Aug 2, 2023

The pressure at the cathode for the PEM model should be higher than atmospheric pressure. Creating issue per prior discussions.
@nRiccobo nRiccobo added the enhancement New feature or request label Aug 2, 2023
@nRiccobo nRiccobo self-assigned this Aug 2, 2023
@nRiccobo nRiccobo mentioned this issue Aug 9, 2023
Open
nRiccobo added a commit to nRiccobo/electrolyzer that referenced this issue Aug 9, 2023
@nRiccobo
Issue NREL#61: Update Cathod Pressure to be 30bar
37dfe92 
- added P_STD from scipy physical constants, which is 1 bar in Pascals
- mods to calc_open_circuit_voltage() include updated p_cathode, split up partial pressures for hydrogen/oxygen according to Dalton's law.

Issue NREL#63: Nernst equation was incorrect. This issue only became became apparent when adjusting cathode pressure.
- changed E_cell calculation to use the correct partial pressures and replaced R+T with R*T.
- Updated test_cell.py, test_stack.py, test_run_electrolyzer.py to account for the new model change.
- Incomplete is test_run_lcoh.py. Need assistance to adjust lcoh_breakdown.
nRiccobo added a commit that referenced this issue Sep 20, 2023
@nRiccobo
Merge pull request #66 from nRiccobo/update/p_cathode
13c52f8 
Issue #61: Update Cathod Pressure to be 30bar
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nRiccobo nRiccobo

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nRiccobo