Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Number of cycles is dtype=float, should be an integer #51

Open
nRiccobo opened this issue Apr 24, 2023 · 0 comments
Open

Number of cycles is dtype=float, should be an integer #51

nRiccobo opened this issue Apr 24, 2023 · 0 comments

Comments

@nRiccobo
Copy link
Collaborator

The variable, cycles, in electrolyzer/glue_code/run_electrolyzer.py, is initialized as the default float type. It should be an integer.

Can see this by:
Using example_02_electrolyzer, and referring to the df.tail() call. Note that the stack_n_cycles (where n = stack ID), is a float variable.

To fix:
Add dtype=int to the np.zeros call.
cycles=np.zeros((elec_sys.n_stacks, len(power_signal)), dtype=int)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant