Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing output directory validation on Eagle #397

Merged
merged 3 commits into from
Oct 13, 2023

Conversation

nmerket
Copy link
Member

@nmerket nmerket commented Oct 10, 2023

Fixes #393.

Pull Request Description

Allows output directories to start with /lustre/eaglefs on Eagle now.

Checklist

Not all may apply

  • Code changes (must work)
  • Tests exercising your feature/bug fix (check coverage report on Checks -> BuildStockBatch Tests -> Artifacts)
  • Coverage has increased or at least not decreased. Update minimum_coverage in .github/workflows/ci.yml as necessary.
  • All other unit and integration tests passing
  • Update validation for project config yaml file changes
  • Update existing documentation
  • Run a small batch run on Eagle to make sure it all works if you made changes that will affect Eagle
  • Add to the changelog_dev.rst file and propose migration text in the pull request

@nmerket nmerket requested a review from lixiliu October 10, 2023 21:14
@github-actions
Copy link

github-actions bot commented Oct 10, 2023

File Coverage
All files 84%
base.py 89%
eagle.py 79%
exc.py 57%
local.py 50%
postprocessing.py 84%
utils.py 96%
sampler/base.py 79%
sampler/downselect.py 33%
sampler/precomputed.py 93%
sampler/residential_quota.py 61%
test/test_docker.py 33%
test/test_validation.py 97%
workflow_generator/base.py 90%
workflow_generator/commercial.py 53%
workflow_generator/residential_hpxml.py 84%

Minimum allowed coverage is 33%

Generated by 🐒 cobertura-action against 50b25d9

@nmerket nmerket added this to the v2023.10.0 milestone Oct 10, 2023
Copy link
Contributor

@lixiliu lixiliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I learned a thing about x? syntax in regular expression thanks to you!

@nmerket nmerket merged commit 5f3aa9f into develop Oct 13, 2023
6 checks passed
@nmerket nmerket deleted the eagle_path_validation_fix branch October 13, 2023 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minor bug on output dir restriction for buildstock_eagle
2 participants