Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update apply_logic schema #322

Open
rajeee opened this issue Oct 28, 2022 · 1 comment
Open

Update apply_logic schema #322

rajeee opened this issue Oct 28, 2022 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@rajeee
Copy link
Contributor

rajeee commented Oct 28, 2022

Describe the bug
Currently, the apply_logic schema allows the apply_logic to begin as either a map or a list. It also allows not block to be either a list or a map.
The documentation for example shows this:
image

However, currently, and and or blocks can only be a list. Sometimes, when using aliases, it makes sense to define an alias for a certain block and use them in various places, including as a sole child of a 'or' or an 'and' block. Example: https://github.com/NREL/resstock/blob/38c53ea77b55991aef84c195ad7812c6735ce918/facades2-project-file.yml#L344

So, to facilitate such usage, and also to have less surprises, I think it makes sense to allow and and or to also support single-key maps.

This will basically require or-spec and and-spec here to match the not-spec

@rajeee rajeee added the bug Something isn't working label Oct 28, 2022
@rajeee rajeee changed the title Apply Logic parsing Update apply_logic schema Oct 28, 2022
@nmerket
Copy link
Member

nmerket commented Nov 2, 2022

Will this break backwards compatibility with existing project files?

@rajeee rajeee added enhancement New feature or request and removed bug Something isn't working labels Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants