Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

postprocessing crashes when simulation_output_report not in workflow_generator args #290

Open
rajeee opened this issue May 17, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@rajeee
Copy link
Contributor

rajeee commented May 17, 2022

Describe the bug
If workflow_generator args doesn't contain simulation_output_report key in the project yaml, postprocessing crashes

To Reproduce
Steps to reproduce the behavior:

  1. Run a simulation with residential_hpxml workflow generator, but without simulation_output_report key in the args

Expected behavior
Either fail the validation because simulation_output_report key is missing, or run simulation without timeseries output. Crashing instead during postprocessing is not acceptable

Logs

Traceback (most recent call last):
  File "/home/radhikar/buildstock/envs/bsb2/lib/python3.7/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/home/radhikar/buildstock/envs/bsb2/lib/python3.7/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/home/radhikar/buildstock/buildstockbatch2/buildstockbatch/eagle.py", line 750, in <module>
    main()
  File "/home/radhikar/buildstock/buildstockbatch2/buildstockbatch/utils.py", line 98, in run_with_error_capture
    return func(*args, **kwargs)
  File "/home/radhikar/buildstock/buildstockbatch2/buildstockbatch/eagle.py", line 740, in main
    batch.process_results()
  File "/home/radhikar/buildstock/buildstockbatch2/buildstockbatch/base.py", line 603, in process_results
    postprocessing.combine_results(fs, self.results_dir, self.cfg, do_timeseries=do_timeseries)
UnboundLocalError: local variable 'do_timeseries' referenced before assignment

Platform (please complete the following information):

  • Simulation platform: Eagle
  • BuildStockBatch version, branch, or sha: develop
  • resstock or comstock repo version, branch, or sha: resstock
  • Local Desktop OS: [e.g. Windows, Mac, Linux, especially important if running locally]

Additional context
I think we should write validators for each workflow generators.

@rajeee rajeee added the bug Something isn't working label May 17, 2022
@rajeee rajeee assigned rajeee and unassigned rajeee May 17, 2022
@rajeee
Copy link
Contributor Author

rajeee commented Oct 28, 2024

Still an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant