Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Leap Year Issue: readEPW with Pvlib.iotools needs to be year forced for leap years #173

Open
shirubana opened this issue Oct 11, 2019 · 1 comment
Open

Leap Year Issue: readEPW with Pvlib.iotools needs to be year forced for leap years #173

shirubana opened this issue Oct 11, 2019 · 1 comment
Labels
Pvlib v0_3_5

Comments

@shirubana
Copy link
Member

Since we moved to the new PVLib.iotools v0.6.3, we had to implement a 1 hour shift internally on the EPW file. However this causes issues for the leap years since Feb. 28 midnight + 1 hour can give Feb. 29..............

Currently fixed by coercing the year to a non-leap year. Maybe change in the future to a different procedure.
@shirubana shirubana added v0_3_4 Next release Pvlib and removed v0_3_4 Next release labels Oct 11, 2019
@shirubana shirubana added v0_3_5 and removed v0_3_4 Next release labels Aug 10, 2020
@shirubana shirubana changed the title readEPW with Pvlib.iotools needs to be year forced for leap years Leap Year Issue: readEPW with Pvlib.iotools needs to be year forced for leap years Aug 10, 2020
@cdeline
Copy link
Contributor

cdeline commented Oct 2, 2024

Same as #552. Will be fixed in PR #553

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Pvlib v0_3_5
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shirubana @cdeline