Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separation of non-standard and standard units for steam #272

Open
RLiNREL opened this issue Oct 9, 2024 · 1 comment
Open

Separation of non-standard and standard units for steam #272

RLiNREL opened this issue Oct 9, 2024 · 1 comment
Assignees
@RLiNREL
Labels
Units Any issue relating to units of measure

Comments

@RLiNREL
Copy link
Collaborator

RLiNREL commented Oct 9, 2024 •
edited
Loading

Currently, EnergySteamUnitOptions has mixed non-standard and standard units, and when they are pulled into components, they are treated differently using different logics.

There might be a better way to store them separately and handled differently. Need to think through the structure and logics.
@RLiNREL RLiNREL self-assigned this Oct 9, 2024
@RLiNREL RLiNREL mentioned this issue Oct 30, 2024
Merged
@RLiNREL
Copy link
Collaborator Author

RLiNREL commented Oct 30, 2024

Renamed the variable name to reflect the mixed units in PR #294
Moving this issue to Icebox just in case.

@RLiNREL RLiNREL added the Units Any issue relating to units of measure label Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RLiNREL RLiNREL

Labels
Units Any issue relating to units of measure
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@RLiNREL