Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: extend to full profast-based financial model #394

Open
jaredthomas68 opened this issue Oct 25, 2024 · 0 comments
Open

Feature request: extend to full profast-based financial model #394

jaredthomas68 opened this issue Oct 25, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request high priority Need to tackle soon

Comments

@jaredthomas68
Copy link
Collaborator

Make a full profast-based financial model

The current use of ProFAST in HOPP only relates to calculating LCOE (real and nominal) when using the custom financial model. It would be better to have a complete functional financial model that relies exclusively on ProFAST for all financial calculations.

Proposed solution

There are two basic paths to accomplishing this:

  1. Removing all currently implemented financial calculations (mostly cash flows and NPV) from the CustomFinancialModel class and replacing them with calculations from ProFAST. This would be a small lift since a full ProFAST model is already being set up and run in HOPP, but would break many tests. I prefer this option.

  2. Creating a new financial model class (ProFASTFinancialModel) specifically for ProFAST and removing ProFAST from the CustomFinancialModel. The benefit of this approach would be to not break existing tests, etc. However, I am concerned that the existing financial calculations may have unrecognized bugs. I did a small test of option 1 and the NPV values and cash flows were very different between the two models. I tend to trust ProFAST over what is currently in CustomFinancialModel. Given the relative trust I have in each model and the increased effort involved in option 2, I lean toward option 1.

Alternatives considered

Additional context

@jaredthomas68 jaredthomas68 self-assigned this Oct 25, 2024
@jaredthomas68 jaredthomas68 added enhancement New feature or request high priority Need to tackle soon labels Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request high priority Need to tackle soon
Projects
None yet
Development

No branches or pull requests

1 participant