Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

key mismatch for End-use Option(s) #320

Open
scotthess opened this issue Dec 10, 2024 · 2 comments
Open

key mismatch for End-use Option(s) #320

scotthess opened this issue Dec 10, 2024 · 2 comments
Assignees
Labels
feature request Feature requested by user(s)

Comments

@scotthess
Copy link

Key value for geophires_x.OptionList.EndUseOptions should be changed to geophires_x.OptionList.EndUseOption without the "s" in order to match the key for the input file "End-use Option". That way the "-" and " " can be removed to match keys. It is not easy to do with the "s" on the end.
Loving the program!
Thanks

@scotthess
Copy link
Author

same issue for Reservoir Volume Option vs geophires_x.OptionList.ReservoirVolume

@softwareengineerprogrammer softwareengineerprogrammer added the feature request Feature requested by user(s) label Dec 11, 2024
@softwareengineerprogrammer
Copy link
Collaborator

Thanks for this feedback @scotthess. Can you elaborate on how specifically the mismatch is impacting you? (I can think of at least 2 hypothetical ways: (1) text searches of the code base might entail finding both "EndUseOptions." and "EndUseOption."; (2) one might want to find usages programmatically by reference but also have to duplicate effort because they are different enums, which would be the case regardless of whether the literal names were the same.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Feature requested by user(s)
Projects
None yet
Development

No branches or pull requests

2 participants