We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In debug build, the following line will trigger a division-by-zero error, due to HeatingCapacityUser being 0 if the system is not autosized.
if ((std::abs(HeatingCapacityDes - HeatingCapacityUser) / HeatingCapacityUser) > state.dataSize->AutoVsHardSizingThreshold) {
When the system is not autosized, HeatingCapacityUser gets value from the RatedHeatCapacity of the VRF object.
HeatingCapacityUser
RatedHeatCapacity
HeatingCapacityUser = state.dataHVACVarRefFlow->VRF(VRFCond).RatedHeatCapacity;
HeatingCapacityUser is zero because the RatedHeatCapacity field of the HR model is not initialized (so it's defaults to 0).
The following is the code of the VRF FluidTCtrl HR model input reading, the RatedHeatingCapacity is not initialized, only HeatingCapacity is.
thisVrfFluidCtrlHR.RatedEvapCapacity = rNumericArgs(1); thisVrfFluidCtrlHR.RatedCompPowerPerCapcity = rNumericArgs(2); thisVrfFluidCtrlHR.RatedCompPower = thisVrfFluidCtrlHR.RatedCompPowerPerCapcity * thisVrfFluidCtrlHR.RatedEvapCapacity; thisVrfFluidCtrlHR.CoolingCapacity = thisVrfFluidCtrlHR.RatedEvapCapacity; thisVrfFluidCtrlHR.HeatingCapacity = thisVrfFluidCtrlHR.RatedEvapCapacity * (1 + thisVrfFluidCtrlHR.RatedCompPowerPerCapcity);
This is how the VRF FluidTCtrl HP model inits rated heating capacity
thisVrfFluidCtrl.RatedEvapCapacity = rNumericArgs(1); thisVrfFluidCtrl.RatedCompPowerPerCapcity = rNumericArgs(2); thisVrfFluidCtrl.RatedCompPower = thisVrfFluidCtrl.RatedCompPowerPerCapcity * thisVrfFluidCtrl.RatedEvapCapacity; thisVrfFluidCtrl.CoolingCapacity = thisVrfFluidCtrl.RatedEvapCapacity; thisVrfFluidCtrl.RatedHeatCapacity = thisVrfFluidCtrl.RatedEvapCapacity * (1 + thisVrfFluidCtrl.RatedCompPowerPerCapcity); // <- initialized here thisVrfFluidCtrl.HeatingCapacity = thisVrfFluidCtrl.RatedHeatCapacity;
Some additional details for this issue (if relevant):
VariableRefrigerantFlow_FluidTCtrl_HR_5Zone_hardsize.idf.zip
Add to this list or remove from it as applicable. This is a simple templated set of guidelines.
The text was updated successfully, but these errors were encountered:
yujiex
Successfully merging a pull request may close this issue.
Issue overview
In debug build, the following line will trigger a division-by-zero error, due to HeatingCapacityUser being 0 if the system is not autosized.
When the system is not autosized,
HeatingCapacityUser
gets value from theRatedHeatCapacity
of the VRF object.HeatingCapacityUser
is zero because theRatedHeatCapacity
field of the HR model is not initialized (so it's defaults to 0).The following is the code of the VRF FluidTCtrl HR model input reading, the RatedHeatingCapacity is not initialized, only HeatingCapacity is.
This is how the VRF FluidTCtrl HP model inits rated heating capacity
Details
Some additional details for this issue (if relevant):
Defect file
VariableRefrigerantFlow_FluidTCtrl_HR_5Zone_hardsize.idf.zip
Checklist
Add to this list or remove from it as applicable. This is a simple templated set of guidelines.
The text was updated successfully, but these errors were encountered: