-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade dockerize script for github #298
Comments
There appears to be a disconnect between the version identified by the With command line arguments, I forced these versions:
However, when looking at the built images which were then pushed, the "-dev" does not show up for any of them:
That includes the persister, broker, and eventsbroker images, as well, though they are not shown above. I think a fix for this is likely a natural by product of the changes for this ticket. Hank |
I am working through this today and I don't know if there is a great solution here. Some quirks with github:
The two above basically means that we would need to pull down and page through all artifacts and parse the json responses to get the download link. Also to download commit artifacts we need to use the personal access token. Creating a script for this use case seems a bit overkill as it would basically just be replacing downloading the artifact from the GUI and then SCP'ing them to where you want to use the normal dockerize script. |
Personally I think ticket gets closed out, especially as testing will be alot easier when we get the jenkins server deploying our staging code for us |
Currently the script we use to "dockerize" and create images based off our github is directly tied to there being a staging release created. This is obviously not ideal as it means in order to leverage this script to test changes in development we need to create a junk staging release and then delete it after we test.
Also as an aside we are leveraging wget to get the packages instead of leveraging the github api which is much quicker.
This task is complete when the following are achieved:
The text was updated successfully, but these errors were encountered: