New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Required updates for integration workflow #45

Merged

SnowHydrology merged 2 commits into master from jlg/integration-workflow-fix

Mar 20, 2024

Contributor

madMatchstick commented Mar 20, 2024

Includes two fixes to ngen_integration.yaml workflow

Passes cmake build flag -DNGEN_IS_MAIN_PROJECT:BOOL=ON to NOM lib build
Sets topmodel submodule initialize build to false. This allows for actual updates in PRs to be tested. Otherwise, the specific master branch commit pinned in ngen's extern/topmodel will overwrite any local code changes copied to the model's working directory.

See relevant discussions here and here.

Testing

All workflows passed in manual action runs. See job details.

madMatchstick added 2 commits

March 20, 2024 15:57


          include NOM lib flag and don't init topmod submod after local code copy

d67d5f5


          comment update

e114549

madMatchstick requested a review from SnowHydrology

March 20, 2024 20:12

SnowHydrology approved these changes

View reviewed changes

SnowHydrology merged commit f9df576 into master

4 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet