-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workflow code that run topmodel within ngen Framework #42
Conversation
mod-dir: "extern/cfe/" | ||
targets: "cfebmi" | ||
|
||
- name: Build PET |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see PET
being used in any of the ngen
runs here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it is not so can be removed.
|
||
- name: Run Ngen Test | ||
run: | | ||
# Run ngen with topmodel with CFE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, this realization couples noahowp
& cfe
.
Is a topmodel
& CFE
coupling even sensible/common? @SnowHydrology
It's probably best to throw PET
somewhere in the mix. The lib is being built, but not currently used. @stcui007 - I believe I have a bmi_multi_pet_topmodel
realization around somewhere if that helps. -thanks again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tha comment is incorrect. I think it is either topmodel or CFE.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could try to see if you can find your realization file coupling PET with Topmodel? That would save me time if there are intricacies involved. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* testing ngen workflow with tmod-pet * pet config is format ini * pet lib path fix * move topmod data dir? * tmod var map adjust * re-add surfacebmi+topmod run --------- Co-authored-by: Jessica Garrett <[email protected]>
This PR provides a workflow code that incorporate topmodel into the ngen framework by running automated ngen test with topmodel commits.
Additions
.github/workflows/ngen_integration.yaml
data/realization_config_topmodel_ngenCI.json
Removals
Changes
Testing
Passded all automated testing
Screenshots
Notes
Todos
Checklist
Testing checklist
Target Environment support
Accessibility
Other