Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow code that run topmodel within ngen Framework #42

Merged
merged 19 commits into from
Dec 29, 2023

Conversation

stcui007
Copy link
Contributor

@stcui007 stcui007 commented Dec 8, 2023

This PR provides a workflow code that incorporate topmodel into the ngen framework by running automated ngen test with topmodel commits.

Additions

.github/workflows/ngen_integration.yaml
data/realization_config_topmodel_ngenCI.json

Removals

Changes

Testing

Passded all automated testing

Screenshots

Notes

Todos

Checklist

  • [x ] PR has an informative and human-readable title
  • [x ] Changes are limited to a single goal (no scope creep)
  • [x ] Code can be automatically merged (no conflicts)
  • [x ] Code follows project standards (link if applicable)
  • [x ] Passes all existing automated tests
  • [x ] Any change in functionality is tested
  • [x ] New functions are documented (with a description, list of inputs, and expected output)
  • [x ] Placeholder code is flagged / future todos are captured in comments
  • Visually tested in supported browsers and devices (see checklist below 👇)
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • [x ] Reviewers requested with the Reviewers tool ➡️

Testing checklist

Target Environment support

  • Windows
  • [x ] Linux
  • Browser

Accessibility

  • Keyboard friendly
  • Screen reader friendly

Other

  • Is useable without CSS
  • Is useable without JS
  • Flexible from small to large screens
  • No linting errors or warnings
  • JavaScript tests are passing

@madMatchstick madMatchstick self-requested a review December 8, 2023 18:03
@stcui007 stcui007 marked this pull request as ready for review December 18, 2023 16:33
@stcui007 stcui007 changed the title First draft workflow code Workflow code that run topmodel within ngen Framework Dec 18, 2023
mod-dir: "extern/cfe/"
targets: "cfebmi"

- name: Build PET
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see PET being used in any of the ngen runs here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it is not so can be removed.


- name: Run Ngen Test
run: |
# Run ngen with topmodel with CFE
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, this realization couples noahowp & cfe.

Is a topmodel & CFE coupling even sensible/common? @SnowHydrology

It's probably best to throw PET somewhere in the mix. The lib is being built, but not currently used. @stcui007 - I believe I have a bmi_multi_pet_topmodel realization around somewhere if that helps. -thanks again.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tha comment is incorrect. I think it is either topmodel or CFE.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could try to see if you can find your realization file coupling PET with Topmodel? That would save me time if there are intricacies involved. Thanks.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stcui007 - See pr I submitted to your fork. Once that is (squashed &) merged, this pr here should be good to go. -thanks!

* testing ngen workflow with tmod-pet

* pet config is format ini

* pet lib path fix

* move topmod data dir?

* tmod var map adjust

* re-add surfacebmi+topmod run

---------

Co-authored-by: Jessica Garrett <[email protected]>
@madMatchstick madMatchstick merged commit 909942b into NOAA-OWP:master Dec 29, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants