Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5pt] Organize the path for model catalog csv file #310

Open
AliForghani-NOAA opened this issue Mar 1, 2024 · 0 comments
Open

[5pt] Organize the path for model catalog csv file #310

AliForghani-NOAA opened this issue Mar 1, 2024 · 0 comments
Labels
bug Something isn't working enhancement New feature or request low priority ras2fim_V2

Comments

@AliForghani-NOAA
Copy link
Collaborator

AliForghani-NOAA commented Mar 1, 2024

There are two issues regarding catalog file.

Current behavior

1- Currently, the tools/s3_get_models.py has two flags to manage the outputs. These are 1) -tm that specifies the directory for HEC-RAS models, and 2) -tcsv that specified the directory for catalog CSV file. Confusion (or even file misuse) can occur if the user does not intelligently select appropriate inputs for both flags.

2- Also, when running python ras2fim.py, we get a "OWP_ras_models_catalog_HUC8***.csv" in the output folder. If user does not specify -mc flag, this catalog file is copied from the one in "c:\ras2fim_data\OWP_ras_models\OWP_ras_models_catalog_HUC8***.csv". This might not be necessarily correct for the same reasons explained above-- practically, the catalog file can be located in a total different path than the HEC-RAS models.

Expected behavior

1- The `tools/s3_get_models.py' should only have a single flag for the output directory. Running the script should create below items in the output directory:

  • The catalog csv file
  • a sub-folder called "models" that contain all downloaded HEC-RAS models

2- If existence of catalog file is really necessary for the ras2fim run, It is safer to make the -mc flag as required and ask the user to explicitly specify its path, rather than assuming a default path for it, which might be completely unrelated to the input HEC-RAS models.

@AliForghani-NOAA AliForghani-NOAA added bug Something isn't working enhancement New feature or request ras2fim_V2 labels Mar 1, 2024
@RobHanna-NOAA RobHanna-NOAA removed their assignment Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request low priority ras2fim_V2
Projects
None yet
Development

No branches or pull requests

2 participants