Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes service fake publish success issue #974

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

shawncrawley
Copy link
Collaborator

Refs #906

If the error mentioned in the above issue is encountered, I added logic to delete the existing SD file and then try the publish again. The second time, the SD file will be recreated. This was tested prior to committing and opening this PR and it worked like a charm.

Copy link
Contributor

@EdisonOrellana-NOAA EdisonOrellana-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making these changes, this is awesome.
I hadn't investigated exactly why it returned an empty list for matching_services.
Not worth investigating at this time?
Good that this error is being handled.

@shawncrawley shawncrawley merged commit c9f15bf into ti Nov 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants