sat_vapor_pres does not output location of bad temperatures (unless it's on a root pe)

[wfcooke]

If I set
show_all_bad_values = true
in sat_vapor_pres_nml I expect to see reports of locations of bad temperatures in my stdout. I do not.

The issue is that the output line
e.g.

FMS/sat_vapor_pres/include/sat_vapor_pres.inc

Line 1919 in 2b05550

write(iunit,'(a,e10.3,a,i4,a,i6)') 'Bad temperature=',temp(i),' at i=',i,' pe=',mpp_pe()

uses stdout as the output unit.
stdout is only defined for root pe

If I use stderr instead at

FMS/sat_vapor_pres/sat_vapor_pres.F90

Line 816 in 2b05550

stdoutunit = stdout()

I get the output I need.
For readability stdoutunit should probably be changed to stderrunit (and set to stderr) in the sat_vapor_pres codeset.

[rem1776]

@wfcooke Thanks for bringing this up, just submitted PR #1619 which should fix this issue for the next release. With the update it will change the output formatting slightly, from:

Bad temperature= 0.100E+03 at i= 1 j= 1 k= 1 pe= 1

to
WARNING from PE 1: Bad temperature= 0.100E+03 at i= 1 j= 1 k= 1

Which I hope won't cause any issues, but if it does just let me know.