Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix render issues caused by r4ss changes #48

Closed
wants to merge 3 commits into from

Conversation

iantaylor-NOAA
Copy link
Contributor

What is the feature?

How have you implemented the solution?

Does the PR impact any other area of the project, maybe another repo?

  • No

Additional info

The opakapaka model was reading an RDS file that contained the information on both SS3 inputs (data and control), and SS3 output. The inputs did not work with the modified r4ss, so I've added a read of these files directly from github to replace the ones in the RDS file. In the future, the RDS file could be updated using the current r4ss.

@kellijohnson-NOAA
Copy link
Contributor

Closing because these changes were brought into #47 using git cherry-pick

@kellijohnson-NOAA kellijohnson-NOAA deleted the fix-r4ss-changes branch October 18, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants