STY: Use capital W and lowercase m for watts per square meter #859
Conversation
All in W/m**2, one of which was w/m2, so that's consistent now.
|
This PR needs new baselines. @DWesl We need ufs-weather-model PR that includes fv3atm and corresponding atmos_cubed_sphere PRs so that we can generate new baselines and run full regression tests. I do not see such ufs-wm PR. |
|
Would that mean a commit here updating the atmos_cubed_sphere submodule to point at my branch there, then in ufs-weather-model pointing at this one? Should I merge the main/develop branches in each PR before doing so? |
Yes. Merge your fv3atm and atmos_cubed_sphere branches with the corresponding develop branches so that they are not behind, then update .gitmodules and create ufs-weather-model branch. In the ufs-wm PR indicate that new baselines are required. |
|
Now includes changes from NOAA-GFDL/GFDL_atmos_cubed_sphere#356. Now included in ufs-community/ufs-weather-model#2467. There's more steps requested there, but I'm not sure how to complete them. In particular, I assumed that "new baselines required" corresponded to "PR Adds New Tests/Baselines" rather than "PR Updates Baselines", but I'm not sure how to add or update a test or baseline, nor how to run the RT (regression test?) suite. |
|
* develop: Second reconciliation PR from production/RRFSv1 (NOAA-EMC#881) STY: Use capital W and lowercase m for watts per square meter (NOAA-EMC#859)
All in W/m**2, one of which was w/m2, so that's consistent now.
Description
Various places report units of
w/m**2for flux variables. This changes those toW/m**2to make those units machine-readable.Issue(s) addressed
Found the same way as NOAA-GFDL/GFDL_atmos_cubed_sphere#350
Testing
I made the
w/m**2->W/m**2changes in a clone of the global-workflow repository, then ran the model and checked the history files, to find most flux variables were nowW/m**2, none werew/m**2, and two wereW/M**2. I fixed the last two and haven't checked that result yet.I checked this using Intel compilers.