Convert GFS DDTs from blocked data structures to contiguous arrays (now also includes https://github.com/NOAA-EMC/fv3atm/pull/752) #798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…review and testing
…ture/chunked_array_support
…ture/chunked_array_support
…ture/chunked_array_support
…t-NOAA/fv3atm into feature/chunked_array_support_use_it
|
Done. See note in ufs-w-m PR. |
climbfuji
changed the title
Closed
…ture/chunked_array_support_use_it
Move data copying outside of block loop
…ture/chunked_array_support_use_it
…ture/chunked_array_support_use_it
|
@DusanJovic-NOAA @BrianCurtis-NOAA are you able to provide a review here? |
DusanJovic-NOAA
approved these changes
Aug 6, 2024
|
Apologies for merging delay. ufs-community/ccpp-physics#183 has been merged, so this is ready to update. @climbfuji @zach1221 |
|
@climbfuji cubed-sphere 330 is also merged. |
|
@jkbk2004 Thanks for reverting |
|
@climbfuji we will take from here. thanks a lot for all the work! |
jkbk2004
approved these changes
Aug 8, 2024
|
@DusanJovic-NOAA can you resolve the conversation and merge? |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In fv3atm and submodules, convert internal GFS DDTs from blocked data structures to contiguous arrays. This excludes the (external)
GFS_extdiagandGFS_restartDDTs. Also remove theGFS_Datasuper DDT and use the individual DDTs directly.This PR also includes the changes from #752 (Add unit testing from @AlexanderRichert-NOAA).
Issue(s) addressed
Working towards ufs-community/ufs-weather-model#2294
Testing
See ufs-community/ufs-weather-model#2183
Dependencies
Associated PRs: