Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Charnock parameter not set in ST6 #1307

Open
stefanzieger opened this issue Oct 10, 2024 · 0 comments
Open

Charnock parameter not set in ST6 #1307

stefanzieger opened this issue Oct 10, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@stefanzieger
Copy link

stefanzieger commented Oct 10, 2024 •
edited
Loading

Describe the bug
Output field variable CHA is zero when using ST6 source terms.

To Reproduce

bash ./bin/run_test -f -o netcdf -s ST6 -w ST6 ../model ww3_ts1
ncdump -v cha ww3_ts1/ST6/ww3.196806.nc

Expected behavior
cha = 0.0095, ....
@stefanzieger stefanzieger added the bug Something isn't working label Oct 10, 2024
stefanzieger added a commit to stefanzieger/WW3 that referenced this issue Oct 11, 2024
@stefanzieger
Charnock parameter not set in ST6 NOAA-EMC#1307
3780f17 
Functional type is after Janssen (1991):
   CHARN = AHAT / SQRT(1-TAU_WAV/TAU)

Changes
-------
 [x] Compute Charnock parameter in subroutine LFACTOR.
 [x] Add minimum Charock coefficient SIN6AHAT to
     namelist SIN6 (Eqv. to WAM-type ALPHA0).
 [x] Regression test `ww3_ts1` succeeded (output
     changed for ST6 gridded output).
ToDo
----
 [ ] Try alternatives w/ dynamically calculated AHAT.
stefanzieger added a commit to stefanzieger/WW3 that referenced this issue Nov 25, 2024
@stefanzieger
Updates to Charnock parameter not set in ST6 (ticket NOAA-EMC#1307)
dbca9aa 
Previous commit 3780f17

Changes
-------
 [x] Add capped Charnock coefficient. SIN6 namelist parameters
     `CHKCAP`, `CHKINF`, `CHKSIG`. Cap is active for CHKCAP > 0.1
 [x] Add regression test ww3_ts1 -i input_capcha
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@stefanzieger