-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
omplace and hybrid OMP at NCEP #1152
Labels
bug
Something isn't working
Comments
Merged
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
It seems like the threading in the NCEP regression tests is not running as expected. The potential problematic lines of code are:
https://github.com/NOAA-EMC/WW3/blob/develop/regtests/bin/run_cmake_test#L1479-L1490
This triggered an error warning message on hercules + gnu when testing #1145 but closer inspection found that hybrid omp jobs are likely not running as expected even in develop.
This was discovered by @MatthewMasarik-NOAA
To Reproduce
Run the matrix and look closely at the output. Search for "omplace" and/or look at the hybrid jobs and what threading is being done.
Expected behavior
Threading jobs should run w/threads and correctly.
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
This will be addressed before merging #1145
The text was updated successfully, but these errors were encountered: