Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose the g2c API in Fortran #327

Merged
merged 10 commits into from
Nov 26, 2022
Merged

Expose the g2c API in Fortran #327

merged 10 commits into from
Nov 26, 2022

Conversation

edwardhartnett
Copy link
Contributor

@edwardhartnett edwardhartnett commented Nov 21, 2022

The g2c library contains some new g2c_* functions. I need to use them in grb2index testing in NCEPLIBS-grib_util. For that to work well, it would be best to expose these functions in the g2 library.

In the g2 library they will all have the prefix: "g2cf".

So g2cf_open() will open a GRIB2 file, and g2cf_close() will close it, etc.

Part of #328

@edwardhartnett
Copy link
Contributor Author

OK, when this is merged to develop, I can then use these functions to resolve the grib_util testing problems with grb2index.

@edwardhartnett
Copy link
Contributor Author

This will not pass CI until this g2c PR is merged: NOAA-EMC/NCEPLIBS-g2c#384

@edwardhartnett edwardhartnett marked this pull request as ready for review November 24, 2022 13:24
Copy link
Contributor

@AlexanderRichert-NOAA AlexanderRichert-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test on local machine looks good

@edwardhartnett edwardhartnett merged commit 57107a1 into develop Nov 26, 2022
@edwardhartnett edwardhartnett deleted the ejh_g2c branch November 26, 2022 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants