docs: add example for RelativeDname::from_slice #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the PR! Since this indeed seems to be a recurring mistake, perhaps we should add a sentence on all of these (also |
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
WhyNotHugo
force-pushed
the
examples
branch
2 times, most recently
from
b1610b9
to
fd10a26
Compare
|
I've included an example for |
WhyNotHugo
force-pushed
the
examples
branch
4 times, most recently
from
ac3c809
to
8e065ed
Compare
Mostly to make it clear the examples like the following are not valid:
RelativeDname::from_slice(b"_submissions._tcp");
|
I think that’s about it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly to make it clear that
b"_submissions.tcp"is not valid input here.