Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move metadata about each country to one place #182

Open
honai opened this issue Feb 25, 2021 · 0 comments
Open

Move metadata about each country to one place #182

honai opened this issue Feb 25, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@honai
Copy link
Member

honai commented Feb 25, 2021

Currently, you have to modify following code to add a country bundle.

  • src/types/index.ts (type countryIds )
  • src/translations/{ja,en}.js (Add translations)
  • src/containers/EntriesPopup.tsx (add latitude/longitude)

Improve readability by moving these codes in one place.
@honai honai added the enhancement New feature or request label Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@honai