Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.0.7 #122

Merged
merged 9 commits into from
Aug 30, 2024
Merged

1.0.7 #122

merged 9 commits into from
Aug 30, 2024

Conversation

mitchellmanware
Copy link
Collaborator

No description provided.

@kyle-messier
Copy link
Collaborator

@mitchellmanware The url in the DESCRIPTION should be changed to our pkgdown site location (https://niehs.github.io/amadeus/) so that shows up on the CRAN url

@mitchellmanware
Copy link
Collaborator Author

@kyle-messier Got it - I will udpate. Is that worth a resubmission?

I have also added the download badge and working on a CRAN version badge

@kyle-messier
Copy link
Collaborator

@mitchellmanware No, we'll undoubtedly find a whole host of things to update, so let's just wait until we have a decent collection of updates to resubmit.

@mitchellmanware
Copy link
Collaborator Author

The use of message() instead of print() in the error messages for download_data() changed the format of the output. Although the same message is sent to the user's console, it is not registered as the error message by testthat::expect_error. The expected error messages associated with download_data() tests (when acknowledgement = FALSE and directory_to_save = NULL) have been removed from the test. The tests still ensure the function fails when it is supposed to, but does not required a specific message.

@mitchellmanware
Copy link
Collaborator Author

Updated error handling in download_data, process_covariates, and calc_covariates to report error, error-generating arguments, and message using one stop() statement.

Copy link
Collaborator

@kyle-messier kyle-messier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.0.6 --> 1.0.7 yes?

@mitchellmanware
Copy link
Collaborator Author

1.0.6 --> 1.0.7 yes?

Yes, updated to 1.0.7 for resubmission

@mitchellmanware mitchellmanware changed the title 1.0.6 1.0.7 Aug 30, 2024
@mitchellmanware mitchellmanware merged commit 3d374ca into main Aug 30, 2024
10 checks passed
@mitchellmanware mitchellmanware deleted the cran-0816 branch September 9, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants