Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

History fields not calculated due to "history_dimlevel" are still output (as NaNs) #1214

Closed
adrifoster opened this issue Jun 13, 2024 · 3 comments

Comments

@adrifoster
Copy link
Contributor

Seemingly, if you don't calculate a history field because of your dimlevel, we still write out the data, as NaNs. This is kind of confusing and I think we should turn off the hist_addfield for that variable if we don't actually calculate it.

@rgknox apologies if this was already discussed and I missed it!

@rgknox
Copy link
Contributor

rgknox commented Jun 13, 2024

This should be the case (i.e. they should not be written), which variable(s) are not doing this? (hoping not all!)

@adrifoster
Copy link
Contributor Author

Actually nevermind I think this might be an issue with a new variable we (@noahlb123 and I) were trying to make. sorry!

@github-project-automation github-project-automation bot moved this from ❕Todo to ✔ Done in FATES issue board Jun 13, 2024
@rgknox
Copy link
Contributor

rgknox commented Jun 14, 2024

phew.. (wipes sweat off brow)
If you notice its a real bug, lets open this again and we will get it fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

2 participants