Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seed production history output is incorrect #1213

Open
JessicaNeedham opened this issue Jun 13, 2024 · 2 comments
Open

Seed production history output is incorrect #1213

JessicaNeedham opened this issue Jun 13, 2024 · 2 comments

Comments

@JessicaNeedham
Copy link
Contributor

Seed production (carbon from reproductive mass in trees to seed pool) is calculated in EDPhysiologyMod in units of kg C / ha / day. here:

call PRTReproRelease(currentCohort%prt,repro_organ,element_id, &

In FatesHistoryInterfaceMod it gets converted to kg C / m2 / sec here:

ccohort%seed_prod * ccohort%n / m2_per_ha / days_per_year / sec_per_day

The divide by days_per_year is not necessary.

It should equal seed allocation since there is no loss of carbon when reproductive tissues is converted to seeds and sure enough when I multiply by 365 in post-processing they are aligned.

Screenshot 2024-06-12 at 18 07 51

@JessicaNeedham
Copy link
Contributor Author

Branch with a fix is here:
https://github.com/JessicaNeedham/fates/tree/jfn-seed-prod-units

It's very minor so can maybe be rolled in with another PR? But happy to make a PR if that is preferred.

@JessicaNeedham
Copy link
Contributor Author

This will be fixed in #1217

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ❕Todo
Development

No branches or pull requests

1 participant