Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parameters duplicated in EDPftvarcon Receive_PFT() #1185

Open
samsrabin opened this issue Apr 15, 2024 · 1 comment
Open

Parameters duplicated in EDPftvarcon Receive_PFT() #1185

samsrabin opened this issue Apr 15, 2024 · 1 comment
Labels
clean up Simple issues like typos, formatting, style guide alignment, etc.

Comments

@samsrabin
Copy link
Contributor

I happened to notice that at least the following parameters have fates_params%RetrieveParameterAllocate() called for them twice in the Receive_PFT() subroutine of EDPftvarcon:

  • fates_mort_scalar_coldstress
  • fates_mort_scalar_cstarvation
  • fates_mort_upthresh_cstarvation

Basically a non-issue, but I figured I'd document it.
@samsrabin samsrabin added the clean up Simple issues like typos, formatting, style guide alignment, etc. label Apr 15, 2024
@mpaiao
Copy link
Contributor

mpaiao commented Apr 24, 2024

Thanks for spotting it @samsrabin! I agree that we should remove duplicates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
clean up Simple issues like typos, formatting, style guide alignment, etc.
Projects
FATES issue board
Status: ❕Todo
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mpaiao @samsrabin