Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate respiration history variables with incorrect units #1183

Closed
JessicaNeedham opened this issue Apr 5, 2024 · 0 comments · Fixed by #1174
Closed

Duplicate respiration history variables with incorrect units #1183

JessicaNeedham opened this issue Apr 5, 2024 · 0 comments · Fixed by #1174
Labels
clean up Simple issues like typos, formatting, style guide alignment, etc.

Comments

@JessicaNeedham
Copy link
Contributor

There are three respiration history variables that are listed twice but with different units, but in each case they use the same index.

FATES_AR ih_aresp_si gC/m^2/s
FATES_AUTORESP ih_aresp_si kg m-2 s-1
FATES_AR_CANOPY ih_ar_canopy_si gC/m^2/s
FATES_AUTORESP_CANOPY ih_ar_canopy_si kg m-2 s-1
FATES_AR_UNDERSTORY ih_ar_understory_si gC/m^2/s
FATES_AUTORESP_USTORY ih_ar_understory_si kg m-2 s-1

e.g.

call this%set_history_var(vname='FATES_AR', units='gC/m^2/s', &

call this%set_history_var(vname='FATES_AUTORESP', units='kg m-2 s-1', &

I think the correct units for all of them are kg m-2 s-1. In FatesPlantRespPhotosynthMod they are calculated as kg C / indiv / ts and in the history routine get converted to m-2 s-1.

This comment is confusing but I think incorrect:

! bulk fluxes are in gC / m2 / s

@glemieux glemieux added the clean up Simple issues like typos, formatting, style guide alignment, etc. label Apr 22, 2024
@github-project-automation github-project-automation bot moved this from ❕Todo to ✔ Done in FATES issue board May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clean up Simple issues like typos, formatting, style guide alignment, etc.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants