-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding kernel links, displaying documentation urls, tooltips #16
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the first round I only looked over the kernels_and_extensions- links feature. I will do the other ones, when we are finished here.
By the way, you only linked kernels so far - what about the jupyter extensions?
data/kernels_and_extensions.yml
Outdated
Octave: https://github.com/Calysto/octave_kernel | ||
Sage: https://github.com/sagemath/sage | ||
gnuplot: https://github.com/has2k1/gnuplot_kernel | ||
Mathematica: https://github.com/WolframResearch/WolframLanguageForJupyter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one https://github.com/mmatera/iwolfram seems more likely to me to be the correct one. However I am not completely sure. Can you list the instances that name Mathematica kernel?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the URL
University of Münster > Mathematica
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @miwig : can you maybe confirm, that https://github.com/mmatera/iwolfram is the kernel that Münster's Jupyterhub uses for Mathematica?
include/details.md
Outdated
{% if features.programming_languages %} | ||
Programming Languages: | ||
{% for kernel in features.programming_languages %} | ||
{% if Links[kernel] %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will only work if the key in kernels_and_extensions.yaml matches exactly the word, people put in the data.yaml file. What about handling different capitalization? Versions at the end? You have to handle that here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will remove the versions and as stated previously would " | lower" to change user input to lower case and have the keys lowered as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can not see any code that removes the version... do I miss something?
@@ -86,7 +91,7 @@ __Documentation__ | |||
| Persistent disk space | {{ resources.default_persistent_disk }} | {{ resources.max_persistent_disk }} | | |||
|
|||
{% if technicals %} | |||
## Technicals | |||
## Technical |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the 's' wrong, when talking about several technical facts? If yes, we have to also rename the variable...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both are correct, there is a differnce of tone however. Technicals is unconventional and informal while technical is more formal.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You didn't comment so far to:
By the way, you only linked kernels so far - what about the jupyter extensions?
Can you?
matlab 2020b: https://www.mathworks.com/content/dam/mathworks/mathworks-dot-com/support/sysreq/files/system-requirements-release-2020b-linux.pdf | ||
matlab 2022b: https://www.mathworks.com/content/dam/mathworks/mathworks-dot-com/support/sysreq/files/system-requirements-release-2022b-windows.pdf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are no links to Jupyter kernels. And we have the reference in line 22. So you can remove the matlab links here.
- {{ kernel }} {% if Links[kernel] %} [{{ Links[kernel] }}]({{ Links[kernel] }}) | ||
{% else %} | ||
{% endif %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Compare to if else loop of features.programming_language. The else-part contains nothing at the moment...
- gen-files: | ||
scripts: | ||
- docs/gen_detail_pages.py | ||
- macros: | ||
include_dir: include | ||
include_yaml: | ||
- data/kernels_and_extensions.yml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be "kernels_and_extensions.yaml"?
No description provided.