diff --git a/README.md b/README.md index ee0943b..c5a1fef 100644 --- a/README.md +++ b/README.md @@ -54,6 +54,7 @@ git submodule update To build the project locally on a Windows Machine: - Install [Chocolatey](https://chocolatey.org/). +- Optional: update `.\src\.nuget\NEventStore.Persistence.Sql.nuspec` file if needed (before creating relase packages). - Open a Powershell console in Administrative mode and run the build script `build.ps1` in the root of the repository. ## How to contribute @@ -96,6 +97,10 @@ You can leave all values as default. Now your repository is GitFlow enabled. ### Note on Nuget version on Nuspec +Remember to update `.\src\.nuget\NEventStore.Persistence.Sql.nuspec` file if needed (before creating relase packages). + +The .nuspec file is needed because the new `dotnet pack` command has problems dealing with ProjectReferences, submodules get the wrong version number. + While we are on develop branch, (suppose we just bumped major number so the driver version number is 6.0.0-unstablexxxx), we need to declare that this persistence driver depends from a version greater than the latest published. If the latest version of NEventStore 5.x.x wave iw 5.4.0 we need to declare this package dependency as (5.4, 7) diff --git a/build.ps1 b/build.ps1 index 3bb9b94..af3dbd8 100644 --- a/build.ps1 +++ b/build.ps1 @@ -1,6 +1,5 @@ $configurationdefault = "Release" $artifacts = "../../artifacts" -$nugetartifacts = "artifacts" $configuration = Read-Host 'Configuration to build [default: Release] ?' if ($configuration -eq '') { @@ -48,4 +47,4 @@ Write-Host "NuGet Packages creation" #dotnet pack ./src/NEventStore.Persistence.Sql/NEventStore.Persistence.Sql.Core.csproj --no-build -c $configuration -o $artifacts -p:NuspecFile="" -p:NuspecProperties="pippo=$configuration;version=$nugetversion" #Write-Host nuget pack ./src/.nuget/NEventStore.Persistence.Sql.nuspec -properties "version=$nugetversion;configuration=$configuration" -nuget pack ./src/.nuget/NEventStore.Persistence.Sql.nuspec -properties "version=$nugetversion;configuration=$configuration" -OutputDirectory $nugetartifacts \ No newline at end of file +nuget pack ./src/.nuget/NEventStore.Persistence.Sql.nuspec -properties "version=$nugetversion;configuration=$configuration" -OutputDirectory $artifacts \ No newline at end of file diff --git a/src/.nuget/NEventStore.Persistence.Sql.nuspec b/src/.nuget/NEventStore.Persistence.Sql.nuspec index 852c705..230fd0c 100644 --- a/src/.nuget/NEventStore.Persistence.Sql.nuspec +++ b/src/.nuget/NEventStore.Persistence.Sql.nuspec @@ -21,19 +21,24 @@ --> - - - + + + + + + + + - - - + + + - - - + + +