Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

confirmation when using shifterimg login #321

Open
shahzebsiddiqui opened this issue May 6, 2022 · 3 comments
Open

confirmation when using shifterimg login #321

shahzebsiddiqui opened this issue May 6, 2022 · 3 comments

Comments

@shahzebsiddiqui
Copy link

shahzebsiddiqui commented May 6, 2022

@scanon

It would be good if you can show a confirmation when using shifterimg login to login to registry to note that login was successful

 ~/ shifterimg login
default username: siddiq90
default password:

If i do some bogus username it still finishes as if login was successful. I think just a message would help. If there is failure in login i think that should be reported.

 ~/ shifterimg login
default username: xyz
default password:
@shahzebsiddiqui
Copy link
Author

This what docker reports when you login to a registry

[siddiq90@podman01]~% docker login registry.services.nersc.gov
Authenticating with existing credentials for registry.services.nersc.gov
Existing credentials are valid. Already logged in to registry.services.nersc.gov

@scanon
Copy link
Member

scanon commented May 13, 2022

The reason we haven't added this is the authentication process is a bit involved and that part is written in C. So it would be a good bit of work to add. We could add something to the output that makes it clear that the login isn't actually checked.

@shahzebsiddiqui
Copy link
Author

I see yeah it bit unclear when one does shifterimg login that we are registered, yeah some extra output would be useful since i type my credentials and i presume it works but no message doesn't help since i can type incorrect password and nothing will happen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants