-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: amrex spack test failing due to make target #224
Comments
Do you think we could try writing our own test similar to the ones we did in past see https://github.com/buildtesters/buildtest-nersc/tree/devel/buildspecs/apps/amrex directory. |
That makes sense to me -- I can add it to my list. |
Thanks. In the meantime i will report this to spack so hopefully someone can fix this. I saw several other packages failing on makefile target so this might be an issue with the spack framework and not a per package issue. It hard to tell. |
I heard they recently implemented a new Spack test framework. However, I thought that would be in a more recent version. The AMReX smoke test uses an old workaround that they always knew would be temporary. So I'm curious if this could be the reason. |
@etpalmer63 i posted an issue in spack project see #224 |
When I run this myself, simply changing:
to
in Ideally, I would have liked to leave it as
but that lead to the, Do you want me to submit a PR for this change? Or is there a better way to set this up so that the test doesn't need to be updated with each E4S version? |
It's good to be explicit in module load e4s
spack env activate gcc
spack load amrex
<test> In this approach below we can guarantee test will be pinned to correct software module load e4s/23.05
spack env activate gcc
spack load amrex There will be test failures due to changes in As per error in |
@etpalmer63 looping you in on this issue.
CDASH Build
https://my.cdash.org/test/102913132
Link to buildspec file
https://github.com/buildtesters/buildtest-nersc/blob/devel/buildspecs/e4s/spack_test/perlmutter/23.05/amrex.yml
Please describe the issue?
There is an issue with the makefile not having the target to run the test.
The test definition is declared in https://github.com/spack/spack/blob/e4s-23.05/var/spack/repos/builtin/packages/amrex/package.py#L342-L374 i can see this has changed in the
develop
branch.Relevant log output
The text was updated successfully, but these errors were encountered: