Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Author name is mixed up in citation and under the title of data package if it's an organization #2548

Open
justinkadi opened this issue Oct 11, 2024 · 1 comment · Fixed by #2552
Labels
bug citations Related to the CitationView, CitationModel, or Citations collection
Milestone

Comments

@justinkadi
Copy link

Describe the bug
When a data package has an author/creator name that is an organization instead of a normal First/Last name, the order of the words can get mixed up in the Citation and underneath the title of the data package.

To Reproduce
2 Examples where the Creator name is different in the Creator section and underneath the title:
Fresh Eyes on Ice Citizen Scientists
Alaska Department of Fish and Game

Expected behavior
We expect the author name to have words in the correct order for these organizations.

Screenshots
Screen Shot 2024-10-11 at 11 13 56 AM
Screen Shot 2024-10-11 at 11 14 21 AM
Screen Shot 2024-10-11 at 11 14 50 AM
Screen Shot 2024-10-11 at 11 15 05 AM

@justinkadi justinkadi added the bug label Oct 11, 2024
@rushirajnenuji rushirajnenuji added the citations Related to the CitationView, CitationModel, or Citations collection label Oct 11, 2024
@robyngit
Copy link
Member

The issue is that we're identifying the short, lower case words as "non-dropping particles" in a last name. In the first example, we parse the organization name as:

{
    "family": "Scientists",
    "non-dropping-particle": "on",
    "given": "Fresh Eyes Ice Citizen"
}

Since it's difficult to differentiate an organization name from a human name, and we're not following the standard APA format of "Last Name, First Initial" anyways, I think we should not bother trying to parse the author names when they're given as a single string.

robyngit added a commit that referenced this issue Oct 15, 2024
@robyngit robyngit linked a pull request Oct 15, 2024 that will close this issue
@robyngit robyngit added this to the 2.32.0 milestone Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug citations Related to the CitationView, CitationModel, or Citations collection
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants