Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix eslint issues in the file hierarchy table code #2483

Open
6 of 7 tasks
robyngit opened this issue Jul 18, 2024 · 1 comment
Open
6 of 7 tasks

Fix eslint issues in the file hierarchy table code #2483

robyngit opened this issue Jul 18, 2024 · 1 comment
Assignees
@rushirajnenuji
Labels
ADC CI-06 UI to handle deposit of big data packages arctic data center linting & formatting Issues related to eslint and prettier config

Comments

@robyngit
Copy link
Member

robyngit commented Jul 18, 2024 •
edited by rushirajnenuji
Loading

In preparation for extending the file hierarchy table to be used in the editor, we should start with some cleanup of the existing code. This will make it easier to add new functionality and ensure that the code is maintainable. To start, we will address some eslint issues in files that are related to the file hierarchy table.

Fix all eslint issues in the following files:

  • src/js/views/DataItemView.js
  • src/js/views/DataPackageView.js
  • src/js/views/DownloadButtonView.js
  • src/js/views/MetadataView.js
  • src/js/collections/DataPackage.js
  • src/js/models/PackageModel.js

Then:

  • Ensure formatting is still correct with these changes: npm run format
@robyngit robyngit added the linting & formatting Issues related to eslint and prettier config label Jul 18, 2024
@robyngit robyngit added the ADC CI-06 UI to handle deposit of big data packages label Jul 18, 2024
@rushirajnenuji rushirajnenuji mentioned this issue Aug 8, 2024
Merged
rushirajnenuji added a commit that referenced this issue Aug 29, 2024
@rushirajnenuji
Fix eslint issues
c690d7e 
Ref #2483
rushirajnenuji added a commit that referenced this issue Aug 29, 2024
@rushirajnenuji
Fix ES Linting errors for DataONEObject & Package model
b4d877d 
Fix ES Linting errors for DataONEObject & Package model
Ref: #2483
@robyngit
Copy link
Member Author

Note that I'm going to fix the remaining MetadataView linting errors as part of #1758

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rushirajnenuji rushirajnenuji

Labels
ADC CI-06 UI to handle deposit of big data packages arctic data center linting & formatting Issues related to eslint and prettier config
Projects
Arctic Data Center Management Plan Deliverables
Status: No status
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rushirajnenuji @robyngit