Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocomplete showing more specific concepts before more generic #448

Closed
CaseyTa opened this issue Jul 28, 2023 · 5 comments
Closed

Autocomplete showing more specific concepts before more generic #448

CaseyTa opened this issue Jul 28, 2023 · 5 comments
Assignees

Comments

@CaseyTa
Copy link

CaseyTa commented Jul 28, 2023

Testing on https://ui.ci.transltr.io/

  • Typed in "type 2 diabetes", but "type 2 diabetes mellitus" only shows up on the 3rd page of autocomplete results (click "Show More" twice)
  • Typed in "heart disorde", but "heart disorder" shows up on the 2nd page of results
  • Typed in "alzheime", but "alzheimer disease" shows up on the 2nd page of results. Typing in "alzheimer" (adding in the last 'r') does bring up "alzheimer disease" to the top result
  • Typed in "muscular dystroph", but "muscular dystrophy" shows up below 2 other more specific forms, including an "Muscular Dystrohpy, Non-human Animal" (but it is on the 1st page of results at least)
  • Typed in "multiple sclerosi", but "multiple sclerosis" shows up 4th, below some unrelated conditions
@khanspers
Copy link

Same for Charcot-Marie-Tooth Disease:

  • Typing in "Charc" and autocompete ONLY lists specific sub-types of this disease (several autocomplete pages), not the parent term (MONDO:0015626). Typing in "Charcot-Marie" and the expected generic term shows up at the top.

@sstemann sstemann added this to the D: Fall - 2023 milestone Sep 18, 2023
@sstemann
Copy link

seems related to #447

@dnsmith124
Copy link
Collaborator

@gaurav @Genomewide could you two take a look into these cases? Since the UI is just displaying what the Name Resolver sends to us there's not really anything I can do to adjust these results aside from changing the curie prefix or biolink type we filter by, and I'd want @Genomewide's approval before doing so.

@gaurav
Copy link

gaurav commented Sep 30, 2023

I've moved the first two cases into separate issues, since the place to start with those issues are relatively straightforward. The third one is now fixed (yay!), but the fix for the last two aren't clear to me. We could implement sorting by the shortest preferred name (TranslatorSRI/NameResolution#72) and see if that helps with these issues, but I feel like there's a smarter way to proceed there.

@sierra-moxon
Copy link
Member

retested type 2 diabetes, heart disor, alzheime and all look good to me. closing as completed; please reopen if necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants