Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing "compiler" options aren't checked for validity #682

Open
rcabell opened this issue Feb 14, 2023 · 0 comments
Open

Testing "compiler" options aren't checked for validity #682

rcabell opened this issue Feb 14, 2023 · 0 comments

Comments

@rcabell
Copy link
Collaborator

rcabell commented Feb 14, 2023

Expected Behavior

Compiler names passed to the testing framework should a) correspond to actual compiler names (gfortran) or b) at least the general suite name used by modules (gnu) and if an invalid item is supplied, the failure in ./configure should be caught instead of letting things fail in byzantine ways later.

Current Behavior

Using gfortran as the compiler name will appear to work at first, but this is passed part-and-parcel to the configure script, which expects gfort and fails (silently, in this case) and then compilation fails later.

Possible Solution

Rename run_tests.py command line option from compiler to configure type or somesuch, or have a reasonable mapping between common compiler names and what configure expects. OR, barring that, catch the error and fail fast with a informative error.

Steps to Reproduce (for bugs)

  1. Run run_tests.py with --compiler gfortran
  2. Watch it fail
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant