Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table parameters overwritten by 2D parameters in single-point simulation #76

Open
CharlesZheZhang opened this issue Apr 12, 2023 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@CharlesZheZhang
Copy link
Collaborator

For crop model and wetland model, single-point simulation reads parameter values from the table and regional simulation from 2D parameters from setup file.
However, when these 2D parameters requested by regional simulation would overwrite table parameters in single-point simulation, occurred in transferring in variables in BiochemVarInMod.F90 and WaterVarInMod.F90.

For example in crop planting date:

if ( OptCropModel == 1 ) then
noahmp%biochem%param%DatePlanting = NoahmpIO%PLANTING(I,J)
noahmp%biochem%param%DateHarvest = NoahmpIO%HARVEST(I,J)
noahmp%biochem%param%GrowDegDayEmerg = NoahmpIO%SEASON_GDD(I,J) / 1770.0 * &
noahmp%biochem%param%GrowDegDayEmerg
noahmp%biochem%param%GrowDegDayInitVeg = NoahmpIO%SEASON_GDD(I,J) / 1770.0 * &
noahmp%biochem%param%GrowDegDayInitVeg
noahmp%biochem%param%GrowDegDayPostVeg = NoahmpIO%SEASON_GDD(I,J) / 1770.0 * &
noahmp%biochem%param%GrowDegDayPostVeg
noahmp%biochem%param%GrowDegDayInitReprod = NoahmpIO%SEASON_GDD(I,J) / 1770.0 * &
noahmp%biochem%param%GrowDegDayInitReprod
noahmp%biochem%param%GrowDegDayMature = NoahmpIO%SEASON_GDD(I,J) / 1770.0 * &
noahmp%biochem%param%GrowDegDayMature
endif

When 2D crop input is missing, hard-coded values (126 and 290) are used in IO_code/module_NoahMP_hrldas_driver.F:

https://github.com/NCAR/hrldas/blob/dca5c8554cec5c8b7edc1c76d8585c6e37b40744/hrldas/IO_code/module_NoahMP_hrldas_driver.F#L277-L284

Suggest change:

  1. in IO_code/module_hrldas_io_netcdf.F, when reading 2D crop input, if variables are missing, pass default value from table.
  2. merge two variable names, NoahmpIO%PLANTING(I,J) from 2D file and NoahmpIO%PLTDAY(CropType) from table.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants