Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize date/time variables in set_env and common run scripts #61

Open
fossell opened this issue Sep 14, 2021 · 1 comment
Open
Assignees
Labels
type: enhancement Improve something that it is currently doing

Comments

@fossell
Copy link
Collaborator

fossell commented Sep 14, 2021

Date/Time information (startdate, fhr, etc.) are set multiple times in set_env for each component sincce each component run script historically used a different environmental variable name.

Consolidate these into one setting of date/time in set_env and modify run scriptst to use the same environmental variable name.

@fossell fossell added priority: high High Priority type: enhancement Improve something that it is currently doing labels Sep 14, 2021
@fossell fossell added this to the Version 3.5 milestone Sep 14, 2021
@fossell fossell self-assigned this Sep 14, 2021
@fossell
Copy link
Collaborator Author

fossell commented Sep 22, 2021

This may not be as straight forward as we hoped due to quite a bit of customization/flexibility in processing different dates/times for each component for different cases. Examples:

Sandy: Same start date, start fhr, end fhr for all components. But fhr increment is 1 hour for UPP and Python, but only 3 hourly for MET (assuming due to obs availability; and for Snow case).

Derecho: Same start date and beg fhr, end fhr, and fhr increment for WRF, UPP, Python, MET for d01. But for d02, different beg fhr and end fhr for UPP.

Just with these two examples, it's really only possible to set startdate once and unify that variable. The other variables, well, vary, too much across components and cases. One thing we could do, is at least make all the same variales in set_env.ksh be the same name, e.g. unify startdate, START_TIME, init_time all to be "START_TIME" or whatever is decided. At least then they are all the same variable when setting them .

Suggest a discussion or input from team regarding how to proceed.

@JohnHalleyGotway JohnHalleyGotway added priority: medium Medium Priority and removed priority: high High Priority labels Sep 28, 2021
@fossell fossell removed this from the Version 3.5 milestone Sep 29, 2021
@fossell fossell added this to the Backlog of Development Ideas milestone Aug 24, 2022
@fossell fossell removed the priority: medium Medium Priority label Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Improve something that it is currently doing
Projects
None yet
Development

No branches or pull requests

2 participants